RFR (XS) 8212616: x86_32 build failures after JDK-8210498 (nmethod entry barriers)

Aleksey Shipilev shade at redhat.com
Wed Oct 17 20:54:46 UTC 2018


Thanks Erik, pushed.

-Aleksey

On 10/17/2018 10:20 PM, Erik Österlund wrote:
> Looks great.
> 
> Thanks,
> /Erik
> 
> On 2018-10-17 21:50, Aleksey Shipilev wrote:
>> Thanks Vladimir. Is this trivial? Or, other Reviewers, please?
>>
>> -Aleksey
>>
>> On 10/17/2018 07:26 PM, Vladimir Kozlov wrote:
>>> Looks good.
>>>
>>> Thanks,
>>> Vladimir
>>>
>>> On 10/17/18 10:14 AM, Aleksey Shipilev wrote:
>>>> Bug:
>>>>     https://bugs.openjdk.java.net/browse/JDK-8212616
>>>>
>>>> Fix is to do what nmethod entry barriers patch did for x86_64.ad:
>>>>
>>>> # HG changeset patch
>>>> # User shade
>>>> # Date 1539796271 -7200
>>>> #      Wed Oct 17 19:11:11 2018 +0200
>>>> # Node ID 92a18a1292533c334021aef21a66c5c9bc1b663c
>>>> # Parent  199658d1ef860cdc17055b4fd3e94b057f292fe9
>>>> 8212616: x86_32 build failures after JDK-8210498 (nmethod entry barriers)
>>>> Reviewed-by: XXX
>>>>
>>>> diff -r 199658d1ef86 -r 92a18a129253 src/hotspot/cpu/x86/x86_32.ad
>>>> --- a/src/hotspot/cpu/x86/x86_32.ad     Wed Oct 17 18:31:48 2018 +0200
>>>> +++ b/src/hotspot/cpu/x86/x86_32.ad     Wed Oct 17 19:11:11 2018 +0200
>>>> @@ -619,7 +619,7 @@
>>>>      int framesize = C->frame_size_in_bytes();
>>>>      int bangsize = C->bang_size_in_bytes();
>>>>
>>>> -  __ verified_entry(framesize, C->need_stack_bang(bangsize)?bangsize:0, C->in_24_bit_fp_mode());
>>>> +  __ verified_entry(framesize, C->need_stack_bang(bangsize)?bangsize:0, C->in_24_bit_fp_mode(),
>>>> C->stub_function() != NULL);
>>>>
>>>>      C->set_frame_complete(cbuf.insts_size());
>>>>
>>>> Testing: {x86_32, x86_64} build
>>>>
>>>> Thanks,
>>>> -Aleksey
>>>>
>>
> 




More information about the hotspot-dev mailing list