RFR : 8211106: [windows] Update OS detection code to recognize Windows Server 2019

[Baesken, Matthias]

Hi Alan,  I agree  it is a pity  that   the minor version (dwMinorVersion) was not increased .
Looking at the build number was not my preferred way to handle this .

My understanding  (checked with our  internal  SAP-MS porting guys)  is that the  buildNumber  of  Windows server 2016    will not get larger than
 the minimum introduced  buildNumber of Windows server 2019 .




Best regards, Matthias




> -----Original Message-----
> From: Weijun Wang <weijun.wang at oracle.com>
> Sent: Freitag, 19. Oktober 2018 12:19
> To: Alan Bateman <Alan.Bateman at oracle.com>
> Cc: Baesken, Matthias <matthias.baesken at sap.com>; Bob Vandette
> <bob.vandette at oracle.com>; roger.riggs at oracle.com; hotspot-dev Source
> Developers <hotspot-dev at openjdk.java.net>; core-libs-
> dev at openjdk.java.net
> Subject: Re: RFR : 8211106: [windows] Update OS detection code to
> recognize Windows Server 2019
> 
> According to https://en.wikipedia.org/wiki/Windows_Server:
> 
> Microsoft releases Windows Server in a LTS channel every few years named
> Windows Server 2016, Windows Server 2019, ...
> 
> It also releases in a semi-annual channel named Windows Server, version
> 1803, 1809, ...
> 
> I'm not sure if we can find out from which channel a system is from simply by
> looking at the version number.
> 
> --Max
> 
> > On Oct 19, 2018, at 6:05 PM, Alan Bateman <Alan.Bateman at oracle.com>
> wrote:
> >
> > On 19/10/2018 10:22, Baesken, Matthias wrote:
> >> Thanks for the remarks ,   I updated  my changes , new webrev :
> >>
> >> http://cr.openjdk.java.net/~mbaesken/webrevs/8211106.2/
> >>
> > Do you know if there is anything on the Microsoft site to explain why the
> minor version wasn't bumped? It looks unusual to have both Windows
> Server 2016 and 2019 report the same major and minor versions.
> >
> > -Alan