RFR 8212754 (XS): Build failure: undefined JvmtiSampledObjectAllocEventCollector::object_alloc_is_safe_to_sample

[Aleksey Shipilev]

Bug:
 https://bugs.openjdk.java.net/browse/JDK-8212754

When JVMTI is disabled (e.g. with Minimal VM), jvmtiExport.cpp is not compiled, and so definition is
not present during linkage. This actually manifests in jdk-updates/jdk11u, because memAllocator.cpp
calls this method only there. jdk/jdk has no problematic call from memAllocator.cpp. Still, I
believe the code should not deviate between jdk and jdk11u, so let's push to to development head,
and then backport.

Fix:

# User shade
8212754: Build failure: undefined JvmtiSampledObjectAllocEventCollector::object_alloc_is_safe_to_sample
Reviewed-by: XXX

diff -r d5a96cafdd4a -r f9c30b92d0dc src/hotspot/share/prims/jvmtiExport.hpp
--- a/src/hotspot/share/prims/jvmtiExport.hpp   Wed Oct 17 22:47:59 2018 +0200
+++ b/src/hotspot/share/prims/jvmtiExport.hpp   Mon Oct 22 13:20:21 2018 +0200
@@ -538,7 +538,7 @@
   JvmtiSampledObjectAllocEventCollector()  NOT_JVMTI_RETURN;
   ~JvmtiSampledObjectAllocEventCollector()  NOT_JVMTI_RETURN;
   bool is_sampled_object_alloc_event()    { return true; }
-  static bool object_alloc_is_safe_to_sample();
+  static bool object_alloc_is_safe_to_sample() NOT_JVMTI_RETURN_(false);
 };


Testing: jdk-updates/jdk11u minimal+slowdebug; jdk/jdk {server,minimal}+slowdebug

Thanks,
-Aleksey