RFR(S): 8210381: Obsolete EmitSync

[Doerr, Martin]

Hi Mikael,

builds on PPC64 and s390 and looks fine.

Thanks,
Martin


-----Original Message-----
From: hotspot-dev <hotspot-dev-bounces at openjdk.java.net> On Behalf Of David Holmes
Sent: Mittwoch, 5. September 2018 04:16
To: Mikael Vidstedt <mikael.vidstedt at oracle.com>; HotSpot Open Source Developers <hotspot-dev at openjdk.java.net>
Subject: Re: RFR(S): 8210381: Obsolete EmitSync

Hi Mikael,

This EmitSync eradication looks good to me.

In src/hotspot/cpu/sparc/macroAssembler_sparc.cpp:

2651    Label Egress ;

This label seems unused even before your change.

Thanks,
David

On 5/09/2018 5:36 AM, Mikael Vidstedt wrote:
> 
> Please review this change which obsoletes the EmitSync flag. In particular, I could use some help from ppc, aarch64, and s390 maintainers to verify that the change actually builds and (still) works.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8210381 <https://bugs.openjdk.java.net/browse/JDK-8210381>
> Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8210381/webrev.00/open/webrev/ <http://cr.openjdk.java.net/~mikael/webrevs/8210381/webrev.00/open/webrev/>
> 
> * Background (from bug)
> 
> The experimental EmitSync flag can in theory be used to select which implementation of the synchronization primitives to use. The flag was convenient when the various implementations were compared a long time ago.
> 
> In practice the only implementation that is used and tested today is the default one. The EmitSync flag no longer serves the purpose it used to, and is "Unsafe, Unstable" (the documentation of the flag says so explicitly). It should be obsoleted and later removed.
> 
> Cheers,
> Mikael
>