RFR: 8210131: vmTestbase/nsk/jvmti/scenarios/allocation/AP10/ap10t001/TestDescription.java failed with ObjectFree: GetCurrentThreadCpuTimerInfo returned unexpected error code
Kim Barrett
kim.barrett at oracle.com
Fri Sep 7 18:40:17 UTC 2018
> On Sep 5, 2018, at 2:59 PM, serguei.spitsyn at oracle.com wrote:
>
> Hi Kim,
>
> The fix looks good to me too.
> Thank you for taking care about this!
Thanks for the review.
> One comment below...
>
> On 8/31/18 07:19, Daniel D. Daugherty wrote:
>> On 8/30/18 10:15 PM, Kim Barrett wrote:
>>> […]
>>> CR:
>>> https://bugs.openjdk.java.net/browse/JDK-8210131
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~kbarrett/8210131/open.00/
>>
>> src/hotspot/share/prims/jvmtiEnter.xsl
>> No comments.
>>
>> test/hotspot/jtreg/ProblemList.txt
>> No comments.
>>
>>
>> I verified that the XSL changes will only affect the two functions
>> in question: jvmti_GetCurrentThreadCpuTimerInfo() and
>> jvmti_GetCurrentThreadCpuTime(). Unfortunately, I can't remember
>> why that bit of XSL code only applies to those two functions.
>
> I was puzzled too but seems to understand it now.
Thanks for the explanation. So it seems there might be an opportunity for a little cleanup
in the xsl matching code. I’m not going anywhere near that without a good reason.
More information about the hotspot-dev
mailing list