[12] RFR (S): 8210465: ARM: Object equals abstraction for BarrierSetAssembler

Roman Kennke rkennke at redhat.com
Mon Sep 17 08:28:13 UTC 2018


> PS:
> 
> BarrierSetAssembler* bs =
> BarrierSet::barrier_set()->barrier_set_assembler();
> bs->obj_equals(this, obj1, obj2);
> 
> Just to emit cmp reg, reg looks a bit overkilling for me.

This is intentional. GCs might want to override what they do for
comparing objects. For example, Shenandoah does that.

Thanks,
Roman


> On 09/14/2018 02:54 PM, Aleksei Voitylov wrote:
>> Hi,
>>
>> please review this patch which follows the changes on x86 and AARCH64:
>>
>> Enhancement: https://bugs.openjdk.java.net/browse/JDK-8210465
>> Webrev: http://cr.openjdk.java.net/~avoitylov/webrev.8210465.01/
>>
>> Tested by HotSpot regression tests.
>>
>> Original issue for x86 and AARCH64:
>> https://bugs.openjdk.java.net/browse/JDK-8203157
>>
>> Thanks,
>>
>> -Aleksei
>>
> 
> 




More information about the hotspot-dev mailing list