What's the point of test/hotspot/jtreg/runtime/jsig?

David Holmes david.holmes at oracle.com
Sun Sep 23 13:22:53 UTC 2018


This was done by:

http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/a0cdf5e20489

"8144279: [TESTBUG] hotspot/runtime/jsig/Test8017498.sh should use 
native library build support"

I would have to guess the main test file was not hg added for the 
commit. But I can't find the code review for it.

I've filed:

https://bugs.openjdk.java.net/browse/JDK-821104

Thanks,
David

On 21/09/2018 6:48 PM, David Holmes wrote:
> Hi Severin,
> 
> I would have to guess that this was intended to be converted to a Java 
> test and either the main test file was not hg added, or else ...
> 
> I can't find the changeset that removed the sh file to try and see what 
> happened. Between file renames and repo reorgs hg log doesn't seem to be 
> able to track this.
> 
> David
> 
> On 21/09/2018 11:22 AM, Severin Gehwolf wrote:
>> Hi,
>>
>> test/hotspot/jtreg/runtime/jsig seems to have come in with JDK-8017498.
>> However, corresponding Test8017498.sh seems to have been removed since
>> and nothing exercises this code as far as I can see. I wonder what's
>> the point of it?
>>
>> There are two options as I see it:
>>
>> 1)
>> Remove dead code in test/hotspot/jtreg/runtime/jsig
>>
>> 2)
>> Rework old Test8017498.sh[1] so that it actually uses classes/natives
>> in test/hotspot/jtreg/runtime/jsig.
>>
>> Which one should it be? I can work on a webrev once it's known what do
>> do.
>>
>> Thanks,
>> Severin
>>
>> [1] 
>> http://hg.openjdk.java.net/jdk/jdk/file/352debf44a39/hotspot/test/runtime/jsig/Test8017498.sh 
>>
>>


More information about the hotspot-dev mailing list