RFR(S): 8211145: [ppc] [s390]: Build fails due to -Werror=switch (introduced with JDK-8211029)

[Aleksey Shipilev]

On 09/26/2018 05:45 PM, Schmidt, Lutz wrote:
> Dear all,
> 
> may I please request reviews for this small patch, fixing some “default case missing” issues in platform code (ppc and s390).
> 
> Bug:    https://bugs.openjdk.java.net/browse/JDK-8211145
> Webrev: http://cr.openjdk.java.net/~lucy/webrevs/8211145.00/

*) What is this change in assembler_s390.hpp? These new enum values are not used.

1445     bcondLowOrNotOrdered  =  bcondLow  | bcondNotOrdered,  // float comparisons
1446     bcondHighOrNotOrdered =  bcondHigh | bcondNotOrdered,  // float comparisons
1447     bcondNotLowOrNotOrdered  =  bcondNotLow  | bcondNotOrdered,  // float comparisons
1448     bcondNotHighOrNotOrdered =  bcondNotHigh | bcondNotOrdered,  // float comparisons

*) Stylistically, it seems more consistent to break the line after "default" in some switches, for
example here:

3214     case Bytecodes::_fast_lputfield:
3215       __ pop_l(Z_tos);
3216       break;
3217     default: break;


-Aleksey