RFR : 8211208 : make AllocateHeapAt an unsupported option on AIX - was : RE: AllocateHeapAt disabling on AIX

[Baesken, Matthias]

Please review  this small change  ,  it makes   AllocateHeapAt   an  unsupported option on AIX  
  And  adjusts a number of tests dealing with this flag .

   Webrev/bug :

http://cr.openjdk.java.net/~mbaesken/webrevs/8211208.0/

https://bugs.openjdk.java.net/browse/JDK-8211208

Thanks, Matthias


> -----Original Message-----
> From: Baesken, Matthias
> Sent: Freitag, 28. September 2018 08:43
> To: 'Kharbas, Kishor' <kishor.kharbas at intel.com>; Aleksey Shipilev
> <shade at redhat.com>; David Holmes <david.holmes at oracle.com>;
> 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
> Subject: RE: AllocateHeapAt disabling on AIX
> 
> Hello , you run into  an error :
> 
> "Error in mapping Java heap at the given filesystem directory ..."
> 
> In early VM  startup when setting  -XX:AllocateHeapAt=/where-to-map
> 
> On AIX .
> 
> Best regards, Matthias
> 
> 
> > -----Original Message-----
> > From: Kharbas, Kishor <kishor.kharbas at intel.com>
> > Sent: Donnerstag, 27. September 2018 20:38
> > To: Baesken, Matthias <matthias.baesken at sap.com>; Aleksey Shipilev
> > <shade at redhat.com>; David Holmes <david.holmes at oracle.com>;
> > 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
> > Cc: Kharbas, Kishor <kishor.kharbas at intel.com>
> > Subject: RE: AllocateHeapAt disabling on AIX
> >
> > Hi Matthias,
> > May I ask out of curiosity, whether you see any error using or having this
> > option?
> >
> > -Kishor
> >
> > > -----Original Message-----
> > > From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On
> > > Behalf Of Baesken, Matthias
> > > Sent: Wednesday, September 26, 2018 9:14 AM
> > > To: Aleksey Shipilev <shade at redhat.com>; David Holmes
> > > <david.holmes at oracle.com>; 'hotspot-dev at openjdk.java.net'
> <hotspot-
> > > dev at openjdk.java.net>
> > > Subject: RE: AllocateHeapAt disabling on AIX
> > >
> > > Hi Aleksey and David , sounds like a good idea.
> > >
> > > Thanks for your input !
> > >
> > > > -----Original Message-----
> > > > From: Aleksey Shipilev <shade at redhat.com>
> > > > Sent: Mittwoch, 26. September 2018 18:13
> > > > To: David Holmes <david.holmes at oracle.com>; Baesken, Matthias
> > > > <matthias.baesken at sap.com>; 'hotspot-dev at openjdk.java.net'
> > <hotspot-
> > > > dev at openjdk.java.net>
> > > > Subject: Re: AllocateHeapAt disabling on AIX
> > > >
> > > > On 09/26/2018 06:09 PM, David Holmes wrote:
> > > > > On 26/09/2018 12:02 PM, Baesken, Matthias wrote:
> > > > >> Hi David,  I would like to  print something like  "AllocateHeapAt
> > > > >> not
> > > > supported on AIX" .
> > > > >> And then exit   (probably just ignoring the flag and printing the
> > > > >> message
> > > > might be bad ).
> > > > >>
> > > > >> The constraint functions were suggested to me as an option but  it
> > > > >> looks
> > > > to me they are
> > > > >> Intended for other use cases .
> > > > >
> > > > > Yes, I think a check in argument.cpp would be better.
> > > >
> > > > There is already a similar block there at L3848:
> > > >
> > > > #if defined(_ALLBSD_SOURCE) || defined(AIX)  // UseLargePages is not
> > > > yet supported on BSD and AIX.
> > > >   UNSUPPORTED_OPTION(UseLargePages);
> > > > #endif
> > > >
> > > > ...I think you can add the AllocateHeapAt check nearby, Matthias.
> > > >
> > > > -Aleksey