RFR: 8219241: Provide basic virtualization related info in the hs_error file on linux/windows x86_64

[Baesken, Matthias]

> 
> On 4/04/2019 8:54 pm, Baesken, Matthias wrote:
> >>
> >> My remaining query is why we need the OS specific checks and code in
> >> os-cpu files? Isn't this just cpu specific? Even if a particular OS
> >> doesn't support virtualization, won't the cpuid query simply report "no
> >> virtualization"?
> >>
> >
> > Hi David,  if you are referring to  these  os-cpu files  :
> >
> > src/hotspot/os_cpu/linux_x86/vm_version_linux_x86.cpp
> > src/hotspot/os_cpu/windows_x86/vm_version_windows_x86.cpp
> >
> > we have different coding available  because  I am not aware  of a cross OS
> API/coding to get   the cpu id info.
> > That’s why different coding for LINUX/Windows.
> 
> ?? But there's nothing in those added functions that is Linux specific
> or Windows specific! The only difference is the mechanism for doing
> "inline assembly" and that's compiler specific. So this should just use
> compiler based ifdefs in vm_version_x86.cpp.
> 

Hi David, I see your point.  But I thought we want to reduce the  ifdefs and favor  putting code into the os or os/cpu  specific  files .
But it is true , from a technical point  we could do using the compiler macros .

Best regards, Matthias