RFR 8191278: MappedByteBuffer bulk access memory failures are not handled gracefully

Tobias Hartmann tobias.hartmann at oracle.com
Mon Apr 8 11:21:40 UTC 2019


Hi Jamsheed,

On 05.04.19 15:11, Jamsheed wrote:
> On 04/04/19 7:23 PM, Andrew Haley wrote:
>>> this looks reasonable to me although the code is getting quite complicated to handle this edge case.
>> Yeah, it really is. Can't we just assume that *any* fault in these stubs is
>> caused via Unsafe, and get rid of bool unsafe_copy_code_range?
> 
> Thanks for the feedback Tobias, Andrew, removed  unsafe_copy_code_range.
> 
> webrev: http://cr.openjdk.java.net/~jcm/8191278/webrev.04/

I think what Andrew meant is basically to go with webrev.01:
http://cr.openjdk.java.net/~jcm/8191278/webrev.01/

Right?

Thanks,
Tobias


More information about the hotspot-dev mailing list