RFR: 8219241: Provide basic virtualization related info in the hs_error file on linux/windows x86_64

Baesken, Matthias matthias.baesken at sap.com
Tue Apr 9 12:07:33 UTC 2019


Hi Martin, thanks for your comments.
I added a TODO-comment  about 32bit,  and removed  the linux-only  ifdef  from  vm_version_x86.cpp   :

http://cr.openjdk.java.net/~mbaesken/webrevs/8219241.6/

Best regards, Matthias


> 
> Hi everybody,
> 
> I think it makes sense to have the cpuid available on all x86 platforms.
> However, the current Windows version requires 64 bit because the ABI
> (calling convention) differs between 32 and 64 bit.
> The linux version should work on all x86 platforms which support this kind of
> inline assembler.
> 
> So I suggest to make it compiler dependent:
> One version for Visual Studio with implementation for 64 bit and TODO for 32
> bit.
> One version for other compilers which support such kind of inline assembler.
> 
> Best regards,
> Martin
> 
> 



More information about the hotspot-dev mailing list