RFR(M/S) : 8222154 : upgrade gtest to 1.8.1

Igor Ignatyev igor.ignatyev at oracle.com
Wed Apr 10 00:17:55 UTC 2019


http://cr.openjdk.java.net/~iignatyev//8222154/webrev.00/index.html
> 6852 lines changed: 5104 ins; 742 del; 1006 mod; 

Hi all,

could you please review the patch which upgrades google test framework used by JDK from v1.7 to v1.8.1?

as this might break builds on other platforms, I'd strongly encourage platform maintainers to check if their native compilers are happy w/ upgraded version of gtest. I'm planning to wait for a week so everyone has enough time to test that, please let me know if you need more time.

for the sake of reviewers, I'm publishing the webrevs for small changes done on top of gtest v1.8.1. and as w/ gtest v1.7, we aren't bringing parts of gtest which aren't essential (make, docs, project files, etc).

JBS: https://bugs.openjdk.java.net/browse/JDK-8222154
testing: tier1
webrevs:
 - reverting 8196997[1]: http://cr.openjdk.java.net/~iignatyev//8222154/-8196997/webrev.00/index.html
> 2 lines changed: 0 ins; 2 del; 0 mod; 1

 - changes to make solaris studio happy: http://cr.openjdk.java.net/~iignatyev//8222154/ss/webrev.00/index.html
> 6 lines changed: 4 ins; 0 del; 2 mod;

 - the whole webrev: http://cr.openjdk.java.net/~iignatyev//8222154/webrev.00/index.html

[1] https://bugs.openjdk.java.net/browse/JDK-8196997

Thanks,
-- Igor


More information about the hotspot-dev mailing list