RFR: 8219241: Provide basic virtualization related info in the hs_error file on linux/windows x86_64

[Baesken, Matthias]

Hi,  clang  sets  __GNUC__  too .

I'll  add  the #include "runtime/vm_version.hpp"   inclusion,  probably was  indirectly  included before .

Best regards, Matthias



> -----Original Message-----
> From: David Holmes <david.holmes at oracle.com>
> Sent: Mittwoch, 10. April 2019 07:30
> To: Doerr, Martin <martin.doerr at sap.com>; Baesken, Matthias
> <matthias.baesken at sap.com>; hotspot-dev at openjdk.java.net
> Subject: Re: RFR: 8219241: Provide basic virtualization related info in the
> hs_error file on linux/windows x86_64
> 
> On 9/04/2019 11:30 pm, Doerr, Martin wrote:
> > Hi Matthias,
> >
> >> I can live with that. :)
> > +1
> > Assuming __GNUC__ is defined on all x86 platforms we have except
> Windows.
> 
> Good catch - probably not on OS X, but I removed it and things seem to
> work fine on OS X without it.
> 
> I think there's also a missing:
> 
> #include "runtime/vm_version.hpp"
> 
> in os_linux.cpp.
> 
> David
> 
> > Best regards,
> > Martin
> >
> >
> > -----Original Message-----
> > From: David Holmes <david.holmes at oracle.com>
> > Sent: Dienstag, 9. April 2019 14:59
> > To: Baesken, Matthias <matthias.baesken at sap.com>; hotspot-
> dev at openjdk.java.net; Doerr, Martin <martin.doerr at sap.com>
> > Subject: Re: RFR: 8219241: Provide basic virtualization related info in the
> hs_error file on linux/windows x86_64
> >
> > On 9/04/2019 10:07 pm, Baesken, Matthias wrote:
> >> Hi Martin, thanks for your comments.
> >> I added a TODO-comment  about 32bit,  and removed  the linux-only  ifdef
> from  vm_version_x86.cpp   :
> >>
> >> http://cr.openjdk.java.net/~mbaesken/webrevs/8219241.6/
> >
> > I can live with that. :)
> >
> > Thanks,
> > David
> >
> >> Best regards, Matthias
> >>
> >>
> >>>
> >>> Hi everybody,
> >>>
> >>> I think it makes sense to have the cpuid available on all x86 platforms.
> >>> However, the current Windows version requires 64 bit because the ABI
> >>> (calling convention) differs between 32 and 64 bit.
> >>> The linux version should work on all x86 platforms which support this
> kind of
> >>> inline assembler.
> >>>
> >>> So I suggest to make it compiler dependent:
> >>> One version for Visual Studio with implementation for 64 bit and TODO
> for 32
> >>> bit.
> >>> One version for other compilers which support such kind of inline
> assembler.
> >>>
> >>> Best regards,
> >>> Martin
> >>>
> >>>
> >>