RFR(M/S) : 8222154 : upgrade gtest to 1.8.1

[Igor Ignatyev]

Hi Robin,

that's a very good suggestion, I myself missed gmock functionality several times, so yes I agree we need to get it available as well. doing that, however, will be a bit more effort and disturbance that just upgrading gtest, and as I'm planning to backport this patch into 11u, I'd prefer to bring gmock by a separate RFE.

-- Igor

> On Apr 10, 2019, at 7:02 AM, Robin Westberg <robin.westberg at oracle.com> wrote:
> 
> Hi Igor,
> 
>> On 10 Apr 2019, at 02:17, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>> 
>> http://cr.openjdk.java.net/~iignatyev//8222154/webrev.00/index.html
>>> 6852 lines changed: 5104 ins; 742 del; 1006 mod; 
>> 
>> Hi all,
>> 
>> could you please review the patch which upgrades google test framework used by JDK from v1.7 to v1.8.1?
>> 
>> as this might break builds on other platforms, I'd strongly encourage platform maintainers to check if their native compilers are happy w/ upgraded version of gtest. I'm planning to wait for a week so everyone has enough time to test that, please let me know if you need more time.
>> 
>> for the sake of reviewers, I'm publishing the webrevs for small changes done on top of gtest v1.8.1. and as w/ gtest v1.7, we aren't bringing parts of gtest which aren't essential (make, docs, project files, etc).
> 
> Just a question / suggestion, would it be possible to include the contents of the googlemock folder as well? Back in the days of gtest 1.7 it used to be a separate project, but as of 1.8 it is a part of gtest. I’d argue it's an essential part of gtest, I’m missing that functionality every time I write a test. :)
> 
> Best regards,
> Robin
> 
>> 
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8222154
>> testing: tier1
>> webrevs:
>> - reverting 8196997[1]: http://cr.openjdk.java.net/~iignatyev//8222154/-8196997/webrev.00/index.html
>>> 2 lines changed: 0 ins; 2 del; 0 mod; 1
>> 
>> - changes to make solaris studio happy: http://cr.openjdk.java.net/~iignatyev//8222154/ss/webrev.00/index.html
>>> 6 lines changed: 4 ins; 0 del; 2 mod;
>> 
>> - the whole webrev: http://cr.openjdk.java.net/~iignatyev//8222154/webrev.00/index.html
>> 
>> [1] https://bugs.openjdk.java.net/browse/JDK-8196997
>> 
>> Thanks,
>> -- Igor