RFR(xs): JDK-8222952 - Typo in test/hotspot/jtreg/TEST.groups is causing test harness failures
Jean Christophe Beyler
jcbeyler at google.com
Thu Apr 25 02:45:38 UTC 2019
Yes this is incorrect, I forgot to put the files for the tests (sorry).
This fix is just adding the wrong path...
Sorry about the confusion and waste of time, I got the LGTM and will be
pushing the fix shortly,
Jc
On Wed, Apr 24, 2019 at 7:07 PM Igor Ignatev <igor.ignatyev at oracle.com>
wrote:
> I guess this fix isn’t needed (and is actually incorrect) after the fix
> for 8222935 <https://bugs.openjdk.java.net/browse/JDK-8222935> is
> integrated. CC’ing JC.
>
> — Igor
>
> On Apr 24, 2019, at 5:16 PM, jesper.wilhelmsson at oracle.com wrote:
>
> Thanks Misha!
> /Jesper
>
> On 25 Apr 2019, at 02:12, mikhailo.seledtsov at oracle.com wrote:
>
>
> +1
>
>
> Misha
>
>
>
> On 4/24/19 5:11 PM, Joseph D. Darcy wrote:
>
> Looks fine Jesper; cheers,
>
>
> -Joe
>
>
> On 4/24/2019 4:52 PM, jesper.wilhelmsson at oracle.com wrote:
>
> Hi,
>
>
> Please review this small patch to fix a typo in TEST.groups introduced by
> JDK-8213501. This is causing failures in every tier 5 run.
>
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8222952
>
> Patch:
>
>
> diff --git a/test/hotspot/jtreg/TEST.groups
> b/test/hotspot/jtreg/TEST.groups
>
> --- a/test/hotspot/jtreg/TEST.groups
>
> +++ b/test/hotspot/jtreg/TEST.groups
>
> @@ -439,7 +439,7 @@
>
> # JVMTI tests
>
> vmTestbase_nsk_jvmti = \
>
> vmTestbase/nsk/jvmti \
>
> - vmTestbase/nsk/share/ExceptionCheckingJniEnv
>
> + vmTestbase/nsk/share/jni/ExceptionCheckingJniEnv
>
>
> # JDWP tests
>
> vmTestbase_nsk_jdwp = \
>
>
>
> Thanks,
>
> /Jesper
>
>
>
>
>
>
--
Thanks,
Jc
More information about the hotspot-dev
mailing list