RFR (S) 8222988: Use MonitorLocker rather than MutexLocker when wait/notify used

Daniel D. Daugherty daniel.daugherty at oracle.com
Mon Apr 29 18:53:21 UTC 2019


On 4/26/19 9:10 AM, coleen.phillimore at oracle.com wrote:
> Summary: fixed use cases in code except CMS.
>
> This affects some GC code and runtime code.  It looks like a nice 
> change to me.  Tested with hs tier1-3.
>
> open webrev at http://cr.openjdk.java.net/~coleenp/2019/8222988.01/webrev

src/hotspot/share/runtime/mutexLocker.hpp
     No comments.

src/hotspot/share/runtime/mutexLocker.cpp
     No comments.

src/hotspot/share/runtime/thread.cpp
     No comments.

src/hotspot/share/runtime/vmThread.cpp
     L377:     while(!VMThread::is_terminated()) {
     L378:         ml.wait();
         nit - please decrease indent by 2 spaces (not your fault)
         nit - L377 needs a space before '(' (also not your fault
               and you didn't touch this line)

src/hotspot/share/compiler/abstractCompiler.cpp
src/hotspot/share/compiler/compileBroker.cpp
src/hotspot/share/gc/g1/g1ConcurrentMark.cpp
src/hotspot/share/gc/g1/g1ConcurrentMarkThread.cpp
src/hotspot/share/gc/g1/g1ConcurrentRefineThread.cpp
src/hotspot/share/gc/g1/g1RootProcessor.cpp
src/hotspot/share/gc/g1/g1VMOperations.cpp
src/hotspot/share/gc/g1/g1YoungRemSetSamplingThread.cpp
src/hotspot/share/gc/parallel/gcTaskManager.cpp
src/hotspot/share/gc/shared/gcLocker.cpp
src/hotspot/share/gc/shared/workgroup.cpp
src/hotspot/share/gc/shenandoah/shenandoahStrDedupQueue.cpp
src/hotspot/share/jfr/periodic/sampling/jfrThreadSampler.cpp
src/hotspot/share/jfr/recorder/service/jfrPostBox.cpp
src/hotspot/share/prims/jvmtiRedefineClasses.cpp
src/hotspot/share/runtime/java.cpp
src/hotspot/share/runtime/sweeper.cpp
src/hotspot/share/runtime/vmOperations.cpp
     No comments (checked these via Udiffs).

Thumbs up!

Dan



> bug link https://bugs.openjdk.java.net/browse/JDK-8222988
>
> Thanks,
> Coleen



More information about the hotspot-dev mailing list