RFR (S): 8222534: VerifyBeforeExit is not honored when System.exit is called

[David Holmes]

Hi Dean,

Thanks for taking a look at this.

On 30/04/2019 5:07 pm, dean.long at oracle.com wrote:
> On 4/29/19 8:54 PM, David Holmes wrote:
>> The IdealGraphPrinter::cleanup was deemed unnecessary due to the fact 
>> the process is being blown away anyway. 
> 
> It looks like, without it, tail(TOP_ELEMENT) won't be called to end the 
> XML output.

Good catch! Unfortunately adding the cleanup call resulted in a crash, 
as it seems another thread can be in the middle of outputting an XML 
element when we hit the terminal safepoint and try to issue the final 
XML element:

#  Internal Error (open/src/hotspot/share/utilities/xmlstream.cpp:184), 
pid=32637, tid=32644
#  assert((!inside_attrs()) || VMError::is_error_reported()) failed: 
cannot close element inside attrs
#

I can't see any reason this would be specific to the System.exit case, 
and a fix is beyond the scope of this current bug, so I'll file a new 
bug for this so the compiler team can investigate and fix as needed.

Thanks,
David

> dl