RFR(T): 8226899 Problemlist compiler/rtm tests

Thu Aug 1 19:57:09 UTC 2019

Hi Dan,

On 08/01/2019 04:26 PM, Daniel D. Daugherty wrote:
> Greetings,
> 
> There are a number of Compiler RTM tests failing the JDK14 CI. I'm tired
> of the noise so I'm going to ProblemList all of the sightings that I
> have found:
> 
> $ hg diff
> diff -r 9afbcd27f26f test/hotspot/jtreg/ProblemList.txt
> --- a/test/hotspot/jtreg/ProblemList.txt Thu Aug 01 09:29:13 2019 -0700
> +++ b/test/hotspot/jtreg/ProblemList.txt Thu Aug 01 15:09:59 2019 -0400
> @@ -59,6 +59,16 @@
> 
>   compiler/runtime/Test8168712.java 8211769,8211771 generic-ppc64,generic-ppc64le,linux-s390x
> 
> +compiler/rtm/locking/TestRTMAbortRatio.java 8183263 generic-x64
> +compiler/rtm/locking/TestRTMAbortThreshold.java 8183263 generic-x64
> +compiler/rtm/locking/TestRTMAfterNonRTMDeopt.java 8183263 generic-x64
> +compiler/rtm/locking/TestRTMDeoptOnHighAbortRatio.java 8183263 generic-x64
> +compiler/rtm/locking/TestRTMDeoptOnLowAbortRatio.java 8183263 generic-x64
> +compiler/rtm/locking/TestRTMLockingCalculationDelay.java 8183263 generic-x64
> +compiler/rtm/locking/TestRTMLockingThreshold.java 8183263 generic-x64
> +compiler/rtm/locking/TestUseRTMDeopt.java 8183263 generic-x64
> +compiler/rtm/print/TestPrintPreciseRTMLockingStatistics.java 8183263 generic-x64
> +
> 
> I don't know or care if this is Skylake related or not. The tests
> are failing. They need to be ProblemListed.
> 
> Thanks, in advance, for any questions, comments, or suggestions.

As someone that spent a lot of time fixing these tests on Power and x86_64 I'm
really interested in why in essence these tests are failing at your side.

Previously I mentioned they were working on Skylake for me and I provided
details on how I'm running the tests (please see [0]), but never got a reply on
it.

I do understand that RTM tests can be sometimes brittle in some environments,
like when there are a few CPUs available and jtreg runs them in parallel. This
is not the ideal scenario to test them since the rely on counting RTM abortions
in some cases. So I'm wondering if they executed correctly by the CI. Maybe if
you provide the output for the failure I could spot something obvious. I do see
your list includes now only x86_64.

In either case, I don't want to be a hindrance on problemlisting them, but I do
think it would be good to at least have a look if something simple is being
missed when running the tests.

I tried the tests again on Skylake (because it's only machine I have access atm
with RTM) and, again, all tests pass fine. I don't think that the CPU, provided
it's newer than Skylake would change the result.

Best regards,
Gustavo

[0] https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-June/038609.html

--

$ make test JTREG="OPTIONS=-nativepath:/home/gromero/hg/jdk/jdk/build/linux-x86_64-server-release/support/test/hotspot/jtreg/native/lib" TEST=./test/hotspot/jtreg/compiler/rtm
<snip>
Test selection './test/hotspot/jtreg/compiler/rtm', will run:
* jtreg:./test/hotspot/jtreg/compiler/rtm

Running test 'jtreg:./test/hotspot/jtreg/compiler/rtm'
Passed: compiler/rtm/cli/TestRTMLockingThresholdOption.java
Passed: compiler/rtm/cli/TestRTMLockingCalculationDelayOption.java
Passed: compiler/rtm/cli/TestRTMAbortThresholdOption.java
Passed: compiler/rtm/cli/TestRTMRetryCountOption.java
Passed: compiler/rtm/cli/TestPrintPreciseRTMLockingStatisticsOptionOnSupportedConfig.java
Passed: compiler/rtm/cli/TestRTMSpinLoopCountOption.java
Passed: compiler/rtm/cli/TestUseRTMDeoptOptionOnSupportedConfig.java
Passed: compiler/rtm/cli/TestUseRTMForStackLocksOptionOnSupportedConfig.java
Passed: compiler/rtm/cli/TestUseRTMLockingOptionOnSupportedConfig.java
Passed: compiler/rtm/cli/TestUseRTMXendForLockBusyOption.java
Passed: compiler/rtm/cli/TestUseRTMLockingOptionWithBiasedLocking.java
Passed: compiler/rtm/locking/TestRTMAbortThreshold.java
Passed: compiler/rtm/locking/TestRTMAbortRatio.java
Passed: compiler/rtm/locking/TestRTMAfterNonRTMDeopt.java
Passed: compiler/rtm/cli/TestRTMTotalCountIncrRateOptionOnSupportedConfig.java
Passed: compiler/rtm/locking/TestRTMDeoptOnHighAbortRatio.java
Passed: compiler/rtm/locking/TestRTMDeoptOnLowAbortRatio.java
Passed: compiler/rtm/locking/TestRTMLockingThreshold.java
Passed: compiler/rtm/locking/TestRTMLockingCalculationDelay.java
Passed: compiler/rtm/locking/TestUseRTMAfterLockInflation.java
Passed: compiler/rtm/locking/TestRTMTotalCountIncrRate.java
Passed: compiler/rtm/locking/TestUseRTMDeopt.java
Passed: compiler/rtm/locking/TestUseRTMForInflatedLocks.java
Passed: compiler/rtm/locking/TestUseRTMForStackLocks.java
Passed: compiler/rtm/method_options/TestNoRTMLockElidingOption.java
Passed: compiler/rtm/method_options/TestUseRTMLockElidingOption.java
Passed: compiler/rtm/locking/TestRTMSpinLoopCount.java
Passed: compiler/rtm/print/TestPrintPreciseRTMLockingStatistics.java
Passed: compiler/rtm/locking/TestRTMRetryCount.java
Passed: compiler/rtm/locking/TestUseRTMXendForLockBusy.java
Test results: passed: 30
Report written to /home/gromero/hg/jdk/jdk/build/linux-x86_64-server-release/test-results/jtreg_test_hotspot_jtreg_compiler_rtm/html/report.html
Results written to /home/gromero/hg/jdk/jdk/build/linux-x86_64-server-release/test-support/jtreg_test_hotspot_jtreg_compiler_rtm
Finished running test 'jtreg:./test/hotspot/jtreg/compiler/rtm'
Test report is stored in build/linux-x86_64-server-release/test-results/jtreg_test_hotspot_jtreg_compiler_rtm

==============================
Test summary
==============================
    TEST                                              TOTAL  PASS  FAIL ERROR
    jtreg:./test/hotspot/jtreg/compiler/rtm              30    30     0     0
==============================
TEST SUCCESS

Finished building target 'test' in configuration 'linux-x86_64-server-release'
gromero at moog:~/hg/jdk/jdk$ hg path
default = http://hg.openjdk.java.net/jdk/jdk/
gromero at moog:~/hg/jdk/jdk$ hg id
9afbcd27f26f tip
gromero at moog:~/hg/jdk/jdk$ hg log -vr.
changeset:   55883:9afbcd27f26f
tag:         tip
user:        mikael
date:        Thu Aug 01 09:29:13 2019 -0700
files:       .hgtags
description:
Added tag jdk-14+8 for changeset c0023e364b6f