RFR [XS] : 8229182: runtime/containers/docker/TestMemoryAwareness.java test fails on SLES12

[Bob Vandette]

Matthias,

I added some background to the bug.

Your fix looks fine to me although you’ll still need an “R” Reviewer.

As for the other issue of dealing with insufficient resources (-137), I don’t think the test should have to
deal with that.  There are lots of ways to get tests to fail if the system you are running on doesn’t have sufficient resources.


Bob.


> On Aug 7, 2019, at 3:23 AM, Baesken, Matthias <matthias.baesken at sap.com> wrote:
> 
> Hello, please review the following small change .
>  
> The docker test  TestMemoryAwareness.java  failed on our ppc64le  SLES12 Linux machine .
> It could  not successfully   trigger the expected  OOM ,  error message is :
>  
> java.lang.RuntimeException: Expected to get exit value of [1] 
> 
> at jdk.test.lib.process.OutputAnalyzer.shouldHaveExitValue(OutputAnalyzer.java:396) 
> at TestMemoryAwareness.testOOM(TestMemoryAwareness.java:106) 
> at TestMemoryAwareness.main(TestMemoryAwareness.java:63) 
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) 
> at java.base/java.lang.reflect.Method.invoke(Method.java:566) 
> at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127) 
> at java.base/java.lang.Thread.run(Thread.java:834) 
>  
>  
> After some discussion with Bob Vandette how to make the test more robust ,
> we  looked into additionally  setting   —memory-swappiness   to   0  to  disable anonymous page swapping. 
>  
> https://docs.docker.com/config/containers/resource_constraints/#--memory-swappiness-details
>  
> The test passes with this added setting.
>  
>  
> Bug/webrev :
>  
> https://bugs.openjdk.java.net/browse/JDK-8229182
>  
> http://cr.openjdk.java.net/~mbaesken/webrevs/8229182.0/
>  
> Thanks, Matthias