Advice on how to push changes back for ARMv7-A softfp platforms

Boris Ulasevich boris.ulasevich at bell-sw.com
Fri Aug 9 11:49:00 UTC 2019


Hi Christoph,

I can create webrev for you. Please note that we should not directly 
patch jdk11u. We should push the fix to jdk-jdk, and then backport the 
change to jdk11u. Your patch is not applied cleanly to the upstream 
because of a minor change around exit label. I think for jdk-jdk the 
change can be like this: 
http://cr.openjdk.java.net/~bulasevich/8229352/webrev.00

A good practice for review is to add a test to reproduce the problem.

Did your company (or you personally) signed OCA?

thanks,
Boris

On 09.08.2019 14:04, christoph.goettschkes at microdoc.com wrote:
> Hi Boris,
> 
> thanks a lot for the bug report. I can send my patches and the description
> again to the mailing list using this bug ID now. Since I do not have any
> accounts in your infrastructure, I think I am not able to create and share
> webrevs with you.
> 
> Should I request accounts for cr.openjdk.java.net, or are patches send to
> this mailing list fine as well?
> 
> -- Christoph
> 
> 
> 
> 
> From:   Boris Ulasevich <boris.ulasevich at bell-sw.com>
> To:     christoph.goettschkes at microdoc.com
> Cc:     hotspot-dev at openjdk.java.net
> Date:   2019-08-09 12:38
> Subject:        Re: Advice on how to push changes back for ARMv7-A softfp
> platforms
> 
> 
> 
> Hi Christoph,
> 
> Let me create bug record for you. Here it is:
> https://bugs.openjdk.java.net/browse/JDK-8229352
> 
> Please provide more details on the issue and come up with webrev (I can
> help you). Here are some details on the process:
> https://openjdk.java.net/contribute
> 
> thanks,
> Boris
> 
> On 09.08.2019 13:05, christoph.goettschkes at microdoc.com wrote:
>> Hello,
>>
>> while working with the OpenJDK 11 on an ARMv7-A soft-fp linux based
>> platform, we found some issues in the template interpreter and in the C1
>> JIT compiler. I already send an email to this mailing list some time ago
>> with a patch for one of the issues, but did not receive any feedback.
>>
>> Could you please advice on how to proceed to push these changes back to
>> you?
>>
>> Thanks,
>> Christoph
> 
> 
> 


More information about the hotspot-dev mailing list