RFR (S): 8228857: Refactor PlatformMonitor into PlatformMutex and PlatformMonitor

David Holmes david.holmes at oracle.com
Sun Aug 11 22:25:24 UTC 2019


On 10/08/2019 8:18 am, dean.long at oracle.com wrote:
> Did you set PLATFORM_MONITOR_IMPL_INDIRECT to 1 for debugging non-apple 
> builds and forgot to revert it?

Oops! Yes that was just for testing.

David

> dl
> 
> On 8/8/19 11:25 PM, David Holmes wrote:
>> Okay here is v2 with Kim's non-copyable adjustments and an alternate 
>> approach to the "impl" class so that the PlatformMutex doesn't have to 
>> pay for the unused pthread_cond_t. Trade-off in this scheme is that 
>> PlatformMonitor now has two "impl" pointers so consumes more space.
>>
>> Also made comment changes suggested by Dan.
>>
>> http://cr.openjdk.java.net/~dholmes/8228857/webrev.v2/
>>
>> Thanks,
>> David
>> -----
> 


More information about the hotspot-dev mailing list