RFR(S): 8229254: solaris_x64 build fails

[Kim Barrett]

> On Aug 11, 2019, at 10:47 PM, David Holmes <david.holmes at oracle.com> wrote:
> 
> Hi Boris,
> 
> On 9/08/2019 11:14 pm, Boris Ulasevich wrote:
>> Hi,
>> Please review the following simple change to make solaris_x64 build compilable.
>> Syntax error was brought by JDK-8191278 [1]. The fix is evident.
> 
> Yes looks good.

Looks good to me too.

>> Missing constant issue occurred after JDK-8226238 [2]. I copied workaround for the case of missing EM_AARCH64 constant in system elf.h header from os_linux.cpp implementation.
> 
> I'm really not sure why we keep expanding a Solaris specific structure with entries for architectures the OS does not run on …

I had the same thought, but that’s not the problem at hand.

> That aside the fix seems fine - the value is somewhat arbitrary but doesn't conflict with anything AFAICS.

Not exactly.  This is the ELF instruction set architecture identifier.  183 == 0xB7 - see for example
https://en.wikipedia.org/wiki/Executable_and_Linkable_Format
Those macros are defined in elf.h; presumably the relevant elf.h is old-ish and doesn’t include AARCH64.