RFR (S): 8228857: Refactor PlatformMonitor into PlatformMutex and PlatformMonitor

David Holmes david.holmes at oracle.com
Mon Aug 12 03:58:01 UTC 2019


On 12/08/2019 1:51 pm, Kim Barrett wrote:
>> On Aug 11, 2019, at 6:31 PM, David Holmes <david.holmes at oracle.com> wrote:
>>
>> Hi Dan,
>>
>> On 11/08/2019 10:57 pm, Daniel D. Daugherty wrote:
>>> On 8/9/19 2:25 AM, David Holmes wrote:
>>>> Okay here is v2 with Kim's non-copyable adjustments and an alternate approach to the "impl" class so that the PlatformMutex doesn't have to pay for the unused pthread_cond_t. Trade-off in this scheme is that PlatformMonitor now has two "impl" pointers so consumes more space.
>>>>
>>>> Also made comment changes suggested by Dan.
>>>>
>>>> http://cr.openjdk.java.net/~dholmes/8228857/webrev.v2/
>>>
>>
>> Thanks Dan. Webrev updated in place.
> 
> Looks good.
> 

Thanks Kim!

David


More information about the hotspot-dev mailing list