RFR: 8227054: ServiceThread needs to know about all OopStorage objects

[coleen.phillimore at oracle.com]

The iterator code seems to have taken on a life of it's own, but the 
runtime changes still look good.

Can you put some comment about why is there a singular iterator and what 
its purpose is?  Is there some implicit use I can't find?

+  // Construct a singular iterator.  The only valid operations are
+  // destruction/copy/assignment.
+  Iterator() :
+    _index(singular_index),
+    _limit(singular_index)
+    DEBUG_ONLY(COMMA _category(singular)) {}
+

Thanks,
Coleen

On 8/20/19 3:19 PM, Kim Barrett wrote:
>> On Aug 20, 2019, at 2:23 AM, Erik Osterlund <erik.osterlund at oracle.com> wrote:
>>
>> Hi Kim,
>>
>> Looks good.
> Thanks.
>
>> Thanks,
>> /Erik
>>
>> On 20 Aug 2019, at 00:32, Kim Barrett <kim.barrett at oracle.com> wrote:
>>
>>>> On Aug 12, 2019, at 4:52 AM, Erik Österlund <erik.osterlund at oracle.com> wrote:
>>>> On 2019-08-12 05:26, Kim Barrett wrote:
>>>>>> On Aug 10, 2019, at 3:52 AM, Erik Osterlund <erik.osterlund at oracle.com> wrote:
>>>>>> Apart from those two things, I really liked the approach!
>>>>> Thanks.  Hopefully we’re approaching a conclusion on this change.
>>>> I hope so.
>>> Finally getting back to this; I got distracted by other things.
>>>
>>> I've removed the macros that were bothering you.
>>>
>>> full: http://cr.openjdk.java.net/~kbarrett/8227054/open.03/
>>> incr: http://cr.openjdk.java.net/~kbarrett/8227054/open.03.inc/
>