RFR: 8229836: Remove include of globals.hpp from allocation.hpp

[Stefan Karlsson]

On 2019-08-20 15:51, coleen.phillimore at oracle.com wrote:
> 
> 
> On 8/20/19 8:09 AM, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review this patch to remove the include of globals.hpp from 
>> allocation.hpp.
>>
>> http://cr.openjdk.java.net/~stefank/8229836/webrev.01/
>> https://bugs.openjdk.java.net/browse/JDK-8229836
>>
>> Note this change is just the bare minimum to get it to compile on our 
>> build platforms. I haven't tried to find all files that are missing 
>> explicit includes of globals.hpp.
> 
> http://cr.openjdk.java.net/~stefank/8229836/webrev.01/src/hotspot/share/oops/oopsHierarchy.hpp.udiff.html 
> 
> 
> Is it because globals.hpp was transitively included, that the extern "C" 
> wasn't needed?  Without extern "C" will it mangle the name?

That seems to have been the case.

> 
> This looks like it doesn't need someone else to review it and can be 
> considered trivial.  It doesn't seem to affect the cpu directories so 
> seems unlikely to break other platforms.

Thanks for reviewing.

StefanK

> 
> thanks,
> Coleen
>>
>> Thanks,
>> StefanK
>