RFR: 8229836: Remove include of globals.hpp from allocation.hpp

[Stefan Karlsson]

Thanks for reviewing.

StefanK

On 2019-08-20 18:08, Kim Barrett wrote:
>> On Aug 20, 2019, at 8:09 AM, Stefan Karlsson <stefan.karlsson at oracle.com> wrote:
>>
>> Hi all,
>>
>> Please review this patch to remove the include of globals.hpp from allocation.hpp.
>>
>> http://cr.openjdk.java.net/~stefank/8229836/webrev.01/
>> https://bugs.openjdk.java.net/browse/JDK-8229836
>>
>> Note this change is just the bare minimum to get it to compile on our build platforms. I haven't tried to find all files that are missing explicit includes of globals.hpp.
>>
>> Thanks,
>> StefanK
> 
> Looks good.
> 
> ------------------------------------------------------------------------------
> src/hotspot/share/oops/oopsHierarchy.hpp
>    76 extern "C" bool CheckUnhandledOops;
> 
> Huh! I hadn't realized options polluted the global C namespace. Yet
> another reason to have far fewer :)
> 
> ------------------------------------------------------------------------------
>