RFR: 8234779: Provide idiom for declaring classes noncopyable
Kim Barrett
kim.barrett at oracle.com
Tue Dec 3 07:27:12 UTC 2019
> On Dec 2, 2019, at 2:49 PM, Kim Barrett <kim.barrett at oracle.com> wrote:
>
>> On Dec 2, 2019, at 4:04 AM, Per Liden <per.liden at oracle.com> wrote:
>> I'd also like to suggest that this type of macro belongs in globalDefinitions.hpp rather than macros.hpp, since it feels more akin to ALWAYSINLINE/ATTRIBUTE_ALIGNED/etc than INCLUDE_JVMTI/X86_ONLY/etc.
>
> Yeah, now that you point it out, macros.hpp is definitely the wrong place for it.
> I personally don’t care for the dumping ground that is globalDefinitions.hpp and
> would prefer smaller and more focused headers, but that’s an entirely different
> discussion. I’ll move this new macro there and clean up the patch accordingly
> (there are #include changes that will need adjusting).
Moved macro to globalDefinitions.hpp and updated #includes.
New webrevs:
full: https://cr.openjdk.java.net/~kbarrett/8234779/open.01/
incr: https://cr.openjdk.java.net/~kbarrett/8234779/open.01.inc/
Testing:
mach5 tier1 (linux-x64, windows-x64, solaris-x64, macosx-x64)
linux fastdebug builds for the following:
1. platforms: aarch64, arm32, ppc64le, s390x.
2. x86_64 with shenandoah included.
3. x86_64 minimal configuration.
More information about the hotspot-dev
mailing list