RFR [XS]: 8235243: handle VS2017 15.9 and VS2019 in abstract_vm_version
Doerr, Martin
martin.doerr at sap.com
Tue Dec 3 13:44:40 UTC 2019
Hi Matthias,
looks good. Thanks for updating.
Best regards,
Martin
> -----Original Message-----
> From: hotspot-dev <hotspot-dev-bounces at openjdk.java.net> On Behalf Of
> Baesken, Matthias
> Sent: Dienstag, 3. Dezember 2019 11:48
> To: 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
> Subject: RFR [XS]: 8235243: handle VS2017 15.9 and VS2019 in
> abstract_vm_version
>
> Hello, please review this small enhancement for Visual Studio compiler
> version handling.
>
> The C++ compiler handling coding in abstract_vm_version.cpp currently
> misses handling nicely VS2017 15.9 ("update 9") and VS2019.
> This leads to bad output like "unknown MS VC++:1916" in the hs_err file.
>
> A list of _MSC_VER can be found for example here :
>
> https://en.wikipedia.org/wiki/Microsoft_Visual_C%2B%2B
>
>
>
> Bug/webrev :
>
> https://bugs.openjdk.java.net/browse/JDK-8235243
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8235243.0/
>
>
> Thanks, Matthias
More information about the hotspot-dev
mailing list