RFR [XS]: 8235243: handle VS2017 15.9 and VS2019 in abstract_vm_version
David Holmes
david.holmes at oracle.com
Wed Dec 4 04:57:41 UTC 2019
Looks fine to me too.
(As usual I lament the fact there is no _MSVC_VER_STR available <sigh>)
Thanks,
David
On 3/12/2019 8:48 pm, Baesken, Matthias wrote:
> Hello, please review this small enhancement for Visual Studio compiler version handling.
>
> The C++ compiler handling coding in abstract_vm_version.cpp currently misses handling nicely VS2017 15.9 ("update 9") and VS2019.
> This leads to bad output like "unknown MS VC++:1916" in the hs_err file.
>
> A list of _MSC_VER can be found for example here :
>
> https://en.wikipedia.org/wiki/Microsoft_Visual_C%2B%2B
>
>
>
> Bug/webrev :
>
> https://bugs.openjdk.java.net/browse/JDK-8235243
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8235243.0/
>
>
> Thanks, Matthias
>
More information about the hotspot-dev
mailing list