8235325: build failure on Linux after 8235243 - was : RE: RFR [XS]: 8235243: handle VS2017 15.9 and VS2019 in abstract_vm_version
Baesken, Matthias
matthias.baesken at sap.com
Wed Dec 4 08:49:47 UTC 2019
Thanks fort he reviews . Unfortunately I noticed a bit too late that a " was missing.
Bug/webrev :
https://bugs.openjdk.java.net/browse/JDK-8235325
http://cr.openjdk.java.net/~mbaesken/webrevs/8235325.0/
Best regards, Matthias
> Looks fine to me too.
>
> (As usual I lament the fact there is no _MSVC_VER_STR available <sigh>)
>
> Thanks,
> David
>
> On 3/12/2019 8:48 pm, Baesken, Matthias wrote:
> > Hello, please review this small enhancement for Visual Studio compiler
> version handling.
> >
> > The C++ compiler handling coding in abstract_vm_version.cpp currently
> misses handling nicely VS2017 15.9 ("update 9") and VS2019.
> > This leads to bad output like "unknown MS VC++:1916" in the hs_err file.
> >
> > A list of _MSC_VER can be found for example here :
> >
> > https://en.wikipedia.org/wiki/Microsoft_Visual_C%2B%2B
> >
> >
> >
> > Bug/webrev :
> >
> > https://bugs.openjdk.java.net/browse/JDK-8235243
> >
> > http://cr.openjdk.java.net/~mbaesken/webrevs/8235243.0/
> >
> >
> > Thanks, Matthias
> >
More information about the hotspot-dev
mailing list