RFR (S): 8235403: Further cleanup to test serviceability/sa/ClhsdbCDSCore.java

Ioi Lam ioi.lam at oracle.com
Thu Dec 5 16:21:17 UTC 2019


Looks good to me.

Thanks
- Ioi

On 12/5/19 3:06 AM, Langer, Christoph wrote:
> Hi,
>
> please review this little test cleanup. When JDK-8234625: hs test serviceability/sa/ClhsdbCDSCore.java  fails on macOS 10.15 [0] was reviewed, there were further comments which didn't make it into the commit.
>
> I think the check for MacOS version 10.15 should not be done, the writability check on /cores is enough. I also tried to improve some messages and added a try-with-resource around the usage of a Scanner instance.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8235403
> Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8235403.0/
>
> Thanks
> Christoph
>
> [0] https://bugs.openjdk.java.net/browse/JDK-8234625
>



More information about the hotspot-dev mailing list