RFR (S): 8235403: Further cleanup to test serviceability/sa/ClhsdbCDSCore.java

[Langer, Christoph]

Thanks for the review, Ioi.

> -----Original Message-----
> From: hotspot-dev <hotspot-dev-bounces at openjdk.java.net> On Behalf Of
> Ioi Lam
> Sent: Donnerstag, 5. Dezember 2019 17:21
> To: hotspot-dev at openjdk.java.net
> Subject: Re: RFR (S): 8235403: Further cleanup to test
> serviceability/sa/ClhsdbCDSCore.java
> 
> Looks good to me.
> 
> Thanks
> - Ioi
> 
> On 12/5/19 3:06 AM, Langer, Christoph wrote:
> > Hi,
> >
> > please review this little test cleanup. When JDK-8234625: hs test
> serviceability/sa/ClhsdbCDSCore.java  fails on macOS 10.15 [0] was reviewed,
> there were further comments which didn't make it into the commit.
> >
> > I think the check for MacOS version 10.15 should not be done, the
> writability check on /cores is enough. I also tried to improve some messages
> and added a try-with-resource around the usage of a Scanner instance.
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8235403
> > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8235403.0/
> >
> > Thanks
> > Christoph
> >
> > [0] https://bugs.openjdk.java.net/browse/JDK-8234625
> >