RFR: 8220049: Remove -XX:-ThreadLocalHandshakes

[Doerr, Martin]

Hi Robbin,

thanks for taking care of AIX. Please also remove set_uses_thread_local_poll (see patch below).
Other than that, AIX change looks good.

Thanks,
Martin


diff -r 6f4ed629c1e1 src/hotspot/os/aix/safepointMechanism_aix.cpp
--- a/src/hotspot/os/aix/safepointMechanism_aix.cpp     Tue Dec 10 11:02:48 2019 +0100
+++ b/src/hotspot/os/aix/safepointMechanism_aix.cpp     Tue Dec 10 13:01:38 2019 +0100
@@ -100,7 +100,6 @@
   MemTracker::record_virtual_memory_reserve_and_commit(map_address, map_size, CALLER_PC, mtSafepoint);

   // Use same page for thread local handshakes without SIGTRAP
-  set_uses_thread_local_poll();
   os::make_polling_page_unreadable();
   intptr_t bad_page_val  = reinterpret_cast<intptr_t>(map_address),
            good_page_val = bad_page_val + os::vm_page_size();



> -----Original Message-----
> From: Robbin Ehn <robbin.ehn at oracle.com>
> Sent: Dienstag, 10. Dezember 2019 10:44
> To: hotspot-dev developers <hotspot-dev at openjdk.java.net>; Doerr,
> Martin <martin.doerr at sap.com>
> Subject: RFR: 8220049: Remove -XX:-ThreadLocalHandshakes
> 
> Hi all, please review,
> 
> ThreadLocalHandshakes is obsolete in JDK 14 and this changeset removes the
> flag.
> All platforms except arm32 uses local poll.
> (after https://bugs.openjdk.java.net/browse/JDK-8235410, Enable
> handshakes on Linux x86 (32-bit)
> , which this patch goes on top of)
> When arm32 also have local poll we remove the global poll code.
> 
> Changeset:
> http://cr.openjdk.java.net/~rehn/8220049/v1/webrev/
> Issue:
> https://bugs.openjdk.java.net/browse/JDK-8220049
> 
> Passes t1-7, built arm32, aarch64, sparc-solaris, linux x86/x64, windows x64,
> osx, linux s390x, linux ppc64le
> 
> (note that on x86 there is missníng include in
> src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp,
> --- a/src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp      Tue Dec 10
> 08:47:38 2019 +0100
> +++ b/src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp      Tue Dec 10
> 10:24:14 2019 +0100
> @@ -32,0 +33,1 @@
> +#include "gc/shared/barrierSetAssembler_x86.hpp"
> )
> 
> Martin please have a look on aix changes.
> 
> Thanks, Robbin