RFR: 8220049: Remove -XX:-ThreadLocalHandshakes

[Daniel D. Daugherty]

On 12/10/19 4:43 AM, Robbin Ehn wrote:
> Hi all, please review,
>
> ThreadLocalHandshakes is obsolete in JDK 14 and this changeset removes 
> the flag.
> All platforms except arm32 uses local poll.
> (after https://bugs.openjdk.java.net/browse/JDK-8235410, Enable 
> handshakes on Linux x86 (32-bit)
> , which this patch goes on top of)
> When arm32 also have local poll we remove the global poll code.
>
> Changeset:
> http://cr.openjdk.java.net/~rehn/8220049/v1/webrev/

src/hotspot/cpu/aarch64/globals_aarch64.hpp
src/hotspot/cpu/arm/globals_arm.hpp
src/hotspot/cpu/ppc/globals_ppc.hpp
src/hotspot/cpu/s390/globals_s390.hpp
src/hotspot/cpu/sparc/globals_sparc.hpp
src/hotspot/cpu/x86/globals_x86.hpp
src/hotspot/cpu/zero/globals_zero.hpp
     No comments on the above flag deletions.

src/hotspot/os/aix/safepointMechanism_aix.cpp
     nit - Needs a copyright year update.

src/hotspot/share/aot/aotCodeHeap.cpp
     nit - Needs a copyright year update.

src/hotspot/share/aot/aotCodeHeap.hpp
     No comments.

src/hotspot/share/gc/z/zMark.cpp
     No comments.

src/hotspot/share/runtime/arguments.cpp
     No comments.

src/hotspot/share/runtime/biasedLocking.cpp
   L38: #include "runtime/handshake.hpp"
   L39: #include "runtime/task.hpp"
   L40: #include "runtime/threadSMR.hpp"
   L41: #include "runtime/safepointMechanism.hpp"
       nit - New include is out of order; should be after handshake.hpp.
       No content comments.

src/hotspot/share/runtime/flags/jvmFlagConstraintsRuntime.cpp
     nit - Needs a copyright year update.

src/hotspot/share/runtime/flags/jvmFlagConstraintsRuntime.hpp
     No comments.

src/hotspot/share/runtime/globals.hpp
     No comments.

src/hotspot/share/runtime/handshake.cpp
     No comments.

src/hotspot/share/runtime/safepoint.cpp
     No comments.

src/hotspot/share/runtime/safepointMechanism.cpp
     No comments.

src/hotspot/share/runtime/safepointMechanism.hpp
     No comments.

src/hotspot/share/runtime/sweeper.cpp
     No comments.

src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/BinaryContainer.java
src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/MarkProcessor.java
     nit - Needs a copyright year update (MarkProcessor.java).
     No content comments on the above AOT changes.

src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.aarch64/src/org/graalvm/compiler/hotspot/aarch64/AArch64HotSpotSafepointOp.java
src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotSafepointOp.java
src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.sparc.test/src/org/graalvm/compiler/hotspot/sparc/test/SPARCAllocatorTest.java
src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.sparc/src/org/graalvm/compiler/hotspot/sparc/SPARCHotSpotSafepointOp.java
src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfig.java
     nit - Needs a copyright year update (most of the Graal files).
     No comments on the above Graal changes.

Thumbs up! I only have nit comments above and I don't need
to see a new webrev if you fix that.

Dan


> Issue:
> https://bugs.openjdk.java.net/browse/JDK-8220049
>
> Passes t1-7, built arm32, aarch64, sparc-solaris, linux x86/x64, 
> windows x64, osx, linux s390x, linux ppc64le
>
> (note that on x86 there is missníng include in 
> src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp,
> --- a/src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp      Tue Dec 10 
> 08:47:38 2019 +0100
> +++ b/src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp      Tue Dec 10 
> 10:24:14 2019 +0100
> @@ -32,0 +33,1 @@
> +#include "gc/shared/barrierSetAssembler_x86.hpp"
> )
>
> Martin please have a look on aix changes.
>
> Thanks, Robbin