RFR [XS]: 8235489: handle return values of sscanf calls in hotspot
Langer, Christoph
christoph.langer at sap.com
Wed Dec 11 11:16:26 UTC 2019
Hi Matthias,
your latest webrev looks fine to me.
Can you run this patch through our regression system once more before pushing? (I can see that there is an older version of the patch at the moment...)
Thanks & Best regards
Christoph
> -----Original Message-----
> From: hotspot-dev <hotspot-dev-bounces at openjdk.java.net> On Behalf Of
> Kim Barrett
> Sent: Mittwoch, 11. Dezember 2019 11:14
> To: Baesken, Matthias <matthias.baesken at sap.com>
> Cc: hotspot-dev at openjdk.java.net
> Subject: Re: RFR [XS]: 8235489: handle return values of sscanf calls in hotspot
>
> > On Dec 11, 2019, at 4:21 AM, Baesken, Matthias
> <matthias.baesken at sap.com> wrote:
> >
> >>
> >> please use "char name[sizeof(line)]" rather than copying the size
> expression.
> >>
> >
> > Hi Kim , new webrev using sizeof(line) :
> >
> > http://cr.openjdk.java.net/~mbaesken/webrevs/8235489.4/
>
> This version looks good to me.
>
> > In case I hear no objections, I will push this as XS .
>
> The term used in the HotSpot How-To [0] is “trivial”. This change doesn’t
> look like that,
> esp. with the amount of discussion it engendered.
>
>
> [0] https://wiki.openjdk.java.net/display/HotSpot/HotSpot+How+To
More information about the hotspot-dev
mailing list