RFR: 8235551: BitMap::count_one_bits should use population_count
Claes Redestad
claes.redestad at oracle.com
Wed Dec 11 14:33:29 UTC 2019
On 2019-12-10 23:23, Kim Barrett wrote:
>
> Looks good.
Thanks!
>
> This comment is a bit misleading:
>
> src/hotspot/share/utilities/population_count.hpp
> 37 // Adapted from Hacker's Delight, 2nd Edition, Figure 5-2.
>
> The implementation being used is a combination of that in Figure 5-2
> and another version a bit later in the associated text. I suggest
> changing the comment to say
>
> Adapted From Hacker's Delight, 2nd Edition, Figure 5-2 and the text
> that follows.
>
> That way, someone looking up the reference won't just go "Wait, what?
> That isn't what's in 5-2."
>
Will fix before push.
/Claes
More information about the hotspot-dev
mailing list