RFR(S) 8199290 [TESTBUG] sun.hotspot.WhiteBox$WhiteBoxPermission is not copied

[Ioi Lam]

Hi David,

I had an earlier version (see comments in the JBS page) that discovers 
all the inner classes and copies them. However, some tests may actually 
want to leave out some inner classes (perhaps to test edge cases in 
inner class handling??). I'd rather leave that for a future RFE.

I'll fix the issues you identified below.

Thanks
- Ioi

On 12/15/19 2:40 PM, David Holmes wrote:
> Hi Ioi,
>
> This seems okay to me. I thought perhaps you would "simply" copy all 
> inner classes for a given outer class, but perhaps we don't have a way 
> to actually determine that set of classes? I'm also not sure how this 
> will look if we added another pair ... I don't see how to generalize 
> the logic. But for now to solve this particular problem (not that we 
> seem to have been bitten by it for a while) this seems okay.
>
> I assume this is a debugging leftover though:
>
> +             Thread.dumpStack();
>
> Also style nit:
>
> i<classes.length
>
> spaces around <
>
> Thanks,
> David
>
> On 15/12/2019 9:21 am, Ioi Lam wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8199290
>> http://cr.openjdk.java.net/~iklam/jdk15/8199290-copy-whitebox-inner-cls.v01/ 
>>
>>
>> We have many cases of
>>
>> * @run driver ClassFileInstaller sun.hotspot.WhiteBox
>>
>> which should have been
>>
>> * @run driver ClassFileInstaller sun.hotspot.WhiteBox 
>> sun.hotspot.WhiteBox$WhiteBoxPermission
>>
>> It will be too tedious to modify these cases. So let's just fix 
>> ClassFileInstaller
>> to automatically the sun.hotspot.WhiteBox$WhiteBoxPermission when 
>> WhiteBox is installed.
>>
>> The JarBuilder class used by the AppCDS tests is also modified 
>> similarly.
>>
>> Thanks
>> - Ioi