RFR (S) 8218140: Build failures after JDK-8218041 (Assorted wrong/missing includes)

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Fri Feb 1 11:32:54 UTC 2019


Hi Aleksey,

Thanks for fixing this before we popped up at work :) !!
s390x and linuxppc64 builds are already green, the others
will take a bit longer.

Great, timely work!
  Best, Goetz.


> -----Original Message-----
> From: hotspot-dev <hotspot-dev-bounces at openjdk.java.net> On Behalf Of
> Aleksey Shipilev
> Sent: Donnerstag, 31. Januar 2019 18:12
> To: Stefan Karlsson <stefan.karlsson at oracle.com>; hotspot-
> dev at openjdk.java.net
> Subject: Re: RFR (S) 8218140: Build failures after JDK-8218041 (Assorted
> wrong/missing includes)
> 
> Thanks! No further comments from, say, SAP folks?
> 
> I am going to push this to unbreak jdk/jdk then.
> 
> -Aleksey
> 
> On 1/31/19 5:35 PM, Stefan Karlsson wrote:
> > Looks good.
> >
> > StefanK
> >
> > On 2019-01-31 16:34, Aleksey Shipilev wrote:
> >> On 1/31/19 1:26 PM, Aleksey Shipilev wrote:
> >> Actually, aarch64, arm32, ppc64, s390x are broken. This is the new fix:
> >>    http://cr.openjdk.java.net/~shade/8218140/webrev.02/
> >>
> >> It looks like frame_*.cpp files need to include os.inline.hpp to gain access to
> >> os::uses_stack_guard_pages().
> >>
> >> Testing: Linux {x86_64, aarch64, arm32, ppc64, s390x} compilation
> >>
> >> -Aleksey



More information about the hotspot-dev mailing list