RFR (S) 8217879: hs_err should print more instructions in hex dump

Aleksey Shipilev shade at redhat.com
Fri Feb 1 15:05:52 UTC 2019


Thanks! And pushed.

-Aleksey

On 1/31/19 2:59 PM, Stefan Karlsson wrote:
> Looks good.
> 
> Thanks,
> StefanK
> 
> On 2019-01-31 13:08, Aleksey Shipilev wrote:
>> On 1/28/19 5:48 PM, Aleksey Shipilev wrote:
>>> RFE:
>>>    https://bugs.openjdk.java.net/browse/JDK-8217879
>>>
>>> Fix:
>>>    http://cr.openjdk.java.net/~shade/8217879/webrev.01/
>>>
>>
>> JDK-8217994 [1] is in, so we can simplify the safety logic: just print whatever around the PC, and
>> let os::print_hex_dump handle it itself:
>>    http://cr.openjdk.java.net/~shade/8217879/webrev.06/
>>
>> Testing: local build, eyeballing hs_errs, jdk-submit (running)
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8217994
>>
>> Thanks,
>> -Aleksey
>>




More information about the hotspot-dev mailing list