RFR : 8218276: AIX build fails in tieredThresholdPolicy.cpp
Baesken, Matthias
matthias.baesken at sap.com
Mon Feb 4 15:15:29 UTC 2019
Hi David / Martin , thanks for the reviews .
>
> but I'm puzzled why we don't see a problem elsewhere, even with PCH
> disabled ...
>
I was surprised too that we got an error in this compilation unit.
Best regards, Matthias
> -----Original Message-----
> From: David Holmes <david.holmes at oracle.com>
> Sent: Montag, 4. Februar 2019 13:30
> To: Doerr, Martin <martin.doerr at sap.com>; Baesken, Matthias
> <matthias.baesken at sap.com>; 'hotspot-dev at openjdk.java.net' <hotspot-
> dev at openjdk.java.net>
> Subject: Re: RFR : 8218276: AIX build fails in tieredThresholdPolicy.cpp
>
> +1
>
> but I'm puzzled why we don't see a problem elsewhere, even with PCH
> disabled ...
>
> Thanks,
> David
>
> On 4/02/2019 9:57 pm, Doerr, Martin wrote:
> > Hi Matthias,
> >
> > looks good and trivial.
> >
> > Thanks for fixing.
> > Martin
> >
> >
> > -----Original Message-----
> > From: hotspot-dev <hotspot-dev-bounces at openjdk.java.net> On Behalf
> Of Baesken, Matthias
> > Sent: Montag, 4. Februar 2019 12:28
> > To: 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
> > Subject: RFR : 8218276: AIX build fails in tieredThresholdPolicy.cpp
> >
> > Hello, please review this small build fix for AIX .
> >
> > Currently the AIX builds for jdk/jdk fail with :
> >
> >
> "/rs6000_64/nightly/jdk/src/hotspot/share/runtime/tieredThresholdPolicy.c
> pp",
> > line 481.23: 1540-0129 (S) The qualifier "SafepointSynchronize" is not
> defined in the current scope.
> >
> "/rs6000_64/nightly/jdk/src/hotspot/share/runtime/tieredThresholdPolicy.c
> pp",
> > line 506.23: 1540-0129 (S) The qualifier "SafepointSynchronize" is not
> defined in the current scope.
> >
> > Seems we miss an inclusions.
> >
> >
> > Webrev and bug :
> >
> > http://cr.openjdk.java.net/~mbaesken/webrevs/8218276.0/
> >
> > https://bugs.openjdk.java.net/browse/JDK-8218276
> >
> >
> > Best regards, Matthias
> >
More information about the hotspot-dev
mailing list