RFR(S) [12] : 8218197 : [failurehandler] parent processes shouldn't be killed till their children are handle

Igor Ignatyev igor.ignatyev at oracle.com
Mon Feb 4 17:37:04 UTC 2019


A friendly reminder.

-- Igor

> On Feb 1, 2019, at 8:58 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
> 
> http://cr.openjdk.java.net/~iignatyev//8218197/webrev.00/index.html
>> 25 lines changed: 8 ins; 2 del; 15 mod; 
> 
> Hi all,
> 
> could you please review this small fix for timeout handler?
> after  8205687[1], we start to kill a process to get a core dump. since we gather info from the parent process before its children and killing a parent can kill children, we started to observer  suspiciously disappeared children processes (8176214[2], 8217170[3]). the patch changes the order we gather information, so we never kill a process till we gather from all its children. the other part of the patch fixes html-output.
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8205687
> [2] https://bugs.openjdk.java.net/browse/JDK-8176214
> [3] https://bugs.openjdk.java.net/browse/JDK-8217170
> 
> webrev: http://cr.openjdk.java.net/~iignatyev//8218197/webrev.00/index.html
> JBS: https://bugs.openjdk.java.net/browse/JDK-8218197
> testing: manually verified reports generated for all time-outing multi-processed test on linux, windows, solaris and mac.
> 
> Thanks,
> -- Igor
> 
> 



More information about the hotspot-dev mailing list