RFR(XS): 8218544: Fix build on windows: missing include

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Wed Feb 6 08:38:29 UTC 2019


Hi Thomas,

> I do not understand how 8218041 could have caused this? Plus, does this error
> show only up in our builds, not in Oracles?
I didn't track this down, but somehow transitively the include  of os.inline.hpp
must have disappeared. 
Our build worked with 8217578, but broke with 8218140, and 8218041 was
in between these and caused other similar issues. So I guessed.

Probably others use precompiled headers.

Best regards,
  Goetz.



> 
> Fix looks fine.
> 
> ...Thomas
> 
> 
> 
> 
> On Wed, Feb 6, 2019 at 8:38 AM Lindenmaier, Goetz
> <goetz.lindenmaier at sap.com <mailto:goetz.lindenmaier at sap.com> > wrote:
> 
> 
> 	Hi
> 
> 	the windows build is broken for a few days. This adds the missing
> 	include.
> 	http://cr.openjdk.java.net/~goetz/wr19/8218544-win_build/01/
> 
> 	Please review.
> 
> 	disassembler.obj : error LNK2019: unresolved external symbol "public:
> static char const * __cdecl os::dll_file_extension(void)"
> 
> 	Best regards,
> 	  Goetz.
> 
> 



More information about the hotspot-dev mailing list