RFR 8214719: Deprecate -Xverify:none option

[Remi Forax]

----- Mail original -----
> De: "Harold David Seigel" <harold.seigel at oracle.com>
> À: "Aleksey Shipilev" <shade at redhat.com>, "hotspot-dev" <hotspot-dev at openjdk.java.net>
> Envoyé: Mercredi 6 Février 2019 20:39:28
> Objet: Re: RFR 8214719: Deprecate -Xverify:none option

> Hi Aleksey,
> 
> Thank you for pointing out that I had not acknowledged David's comment.
> I have since entered a response pointing out that users can now use
> AppCDS to get their performance boost because AppCDS code is verified at
> archive time.
> 
> Does the availability of AppCDS allay your concerns about this change?

AppCDS has a cost in term of disk space, so use it is a trade off.

> 
> Thanks, Harold

Rémi

> 
> On 2/6/2019 9:26 AM, Aleksey Shipilev wrote:
>> On 2/6/19 3:18 PM, Harold Seigel wrote:
>>> Please review this change to deprecate the -Xverify:none and -noverify options
>>> in JDK-13.  The
>>> following warning message will be issued when these options are used:
>>>
>>> Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8214719/webrev/index.html
>>> JBS Bug:  https://bugs.openjdk.java.net/browse/JDK-8214719
>> I am against removing this option: it is used to skip verification overhead on
>> known-good class
>> files, and also is used to see if verifier _is_ indeed the performance problem
>> for those cases. I
>> see David Holmes made similar comment in the bug, which was left unacknowledged.
>>
>> -Aleksey