RFR(XS): 8218544: Fix build on windows: missing include
David Holmes
david.holmes at oracle.com
Thu Feb 7 04:59:12 UTC 2019
On 7/02/2019 12:38 am, Lindenmaier, Goetz wrote:
> Hi David, Aleksey,
>
> thanks for reviewing!
>
> Maybe it's because we configure with --enable-aot=no?
> But I don't want to track it down, as the fix is obviously
> needed and correct ... as you confirmed, thanks!
I think, looking closer, that we only build with no-PCH on linux, and so
missed this because the set of inline os functions differs by platform
Cheers,
David
> Best regards,
> Goetz.
>
>> -----Original Message-----
>> From: Aleksey Shipilev <shade at redhat.com>
>> Sent: Mittwoch, 6. Februar 2019 12:58
>> To: David Holmes <david.holmes at oracle.com>; Lindenmaier, Goetz
>> <goetz.lindenmaier at sap.com>; Thomas Stüfe <thomas.stuefe at gmail.com>
>> Cc: hotspot-dev at openjdk.java.net
>> Subject: Re: RFR(XS): 8218544: Fix build on windows: missing include
>>
>> On 2/6/19 12:54 PM, David Holmes wrote:
>>> 8218041 was tested with and without PCH and we do not see any failures in
>> our builds.
>>
>> Same.
>>
>>> Very perplexing.
>>
>> Same.
>>
>>> But reviewed.
>>
>> Same.
>>
>> -Aleksey
>
More information about the hotspot-dev
mailing list