RFR 8214719: Deprecate -Xverify:none option

[forax at univ-mlv.fr]

----- Mail original -----
> De: "David Holmes" <david.holmes at oracle.com>
> À: "Remi Forax" <forax at univ-mlv.fr>, "Harold David Seigel" <harold.seigel at oracle.com>
> Cc: "hotspot-dev" <hotspot-dev at openjdk.java.net>
> Envoyé: Jeudi 7 Février 2019 03:58:12
> Objet: Re: RFR 8214719: Deprecate -Xverify:none option

> Hi Remi,
> 
> On 7/02/2019 8:15 am, Remi Forax wrote:
>> Hi Harold,
>> -noverify is very useful for debugging,
>> i use it either because i think that the verifier has an error (array covariance
>> of value types is a recent example) or because i want to simulate in a test a
>> class that will not be verified at runtime (by example an anonymous classes).
>> 
>> I see no problem to move it under the diagnostic flag but deprecate it (and then
>> its removal) will make my life more painful.
> 
> You can use the -XX flags previously mentioned instead.

you mean, -XX:-BytecodeVerificationRemote and -XX:-BytecodeVerificationLocal

yes, i've just discovered them.

> 
> The existence of -noverify could be seen as a historical error as it's
> defined as a standard launcher flag when at best it should have been a
> -X flag, or more appropriately -XX.
> 

i agree.

> Cheers,
> David

regards,
Rémi

> 
>> 
>> Rémi
>> 
>> ----- Mail original -----
>>> De: "Harold David Seigel" <harold.seigel at oracle.com>
>>> À: "hotspot-dev" <hotspot-dev at openjdk.java.net>
>>> Envoyé: Mercredi 6 Février 2019 15:18:02
>>> Objet: RFR 8214719: Deprecate -Xverify:none option
>> 
>>> Hi,
>>>
>>> Please review this change to deprecate the -Xverify:none and -noverify
>>> options in JDK-13.  The following warning message will be issued when
>>> these options are used:
>>>
>>>       warning: Options -Xverify:none and -noverify were deprecated in
>>>     version 13.0 and will likely be removed in a future release.
>>>
>>> The options were removed from tests that no longer needed them or the
>>> options were changed as needed.
>>>
>>> Open Webrev:
>>> http://cr.openjdk.java.net/~hseigel/bug_8214719/webrev/index.html
>>>
>>> JBS Bug:  https://bugs.openjdk.java.net/browse/JDK-8214719
>>>
>>> The fix was regression tested by running Mach5 tiers 1 and 2 tests and
>>> builds on Linux-x64, Windows, and Mac OS X, Mach5 tiers 3 -5 on
>>> Linux-x64, and by running JCK Lang and VM tests on Linux-x64.
>>>
> >> Thanks, Harold