RFR(S/T) : 8219158 : use 'test.root' property instead of traversing test-src path

David Holmes david.holmes at oracle.com
Wed Feb 20 08:41:07 UTC 2019


On 20/02/2019 5:05 pm, Igor Ignatyev wrote:
> Hi David,
> 
> Hi David,
> 
> Hi David,
> 
> http://cr.openjdk.java.net/~iignatyev//8219158/webrev.0-1/index.html is 
> the incremental webrev w/ bumping  requiredVersion only in hotspot.

Looks good.

Thanks,
David

> -- Igor
> 
>> On Feb 19, 2019, at 10:48 PM, David Holmes <david.holmes at oracle.com 
>> <mailto:david.holmes at oracle.com>> wrote:
>>
>> Hi Igor,
>>
>> On 20/02/2019 4:24 pm, Igor Ignatyev wrote:
>>> Hi David,
>>> you are right, I've filed 8219417 to do that in all test suites and 
>>> sent RFR to jdk-dev alias.
>>
>> I responded to that RFR and I don't think it's the right approach. 
>> This bug should simply update the requiresVersion for the hotspot tests.
>>
>> Thanks,
>> David
>>
>>> -- Igor
>>>> On Feb 19, 2019, at 10:07 PM, David Holmes <david.holmes at oracle.com 
>>>> <mailto:david.holmes at oracle.com>> wrote:
>>>>
>>>> Hi Igor,
>>>>
>>>> On 20/02/2019 3:54 pm, Igor Ignatyev wrote:
>>>>> http://cr.openjdk.java.net/~iignatyev//8219158/webrev.00/index.html
>>>>>> 73 lines changed: 9 ins; 32 del; 32 mod;
>>>>> Hi all,
>>>>> could you please review this trivial clean-up? jtreg4.2-b14 added a 
>>>>> new property 'test.root', this patches replaces all code in hotspot 
>>>>> testbase which determines the root directory w/ simple reading of 
>>>>> this property.
>>>>
>>>> You will have to update the jtreg requiresVersion to b14 to use 
>>>> this, else it will fail for anyone not using b14.
>>>>
>>>> Thanks,
>>>> David
>>>> ----
>>>>
>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8219158
>>>>> webrev: 
>>>>> http://cr.openjdk.java.net/~iignatyev//8219158/webrev.00/index.html
>>>>> testing: vmTestbase/gc/g1/unloading, 
>>>>> vmTestbase/nsk/monitoring/stress, vmTestbase/vm/mlvm/, 
>>>>> vmTestbase/vm/runtime/defmeth
>>>>> Thanks,
>>>>> -- Igor
> 


More information about the hotspot-dev mailing list