8218811: replace open by os::open in hotspot coding - was : open-calls in hotspot code instead of os::open ?

[Baesken, Matthias]

Hi David,  the ones in  open_directory_secure   and   open_directory_secure_cwd   .

Please see the diff of   src/hotspot/os/linux/perfMemory_linux.cpp   from webrev 4  vs.  5  .

320c320
<   RESTARTABLE(os::open(dirname, O_RDONLY|O_NOFOLLOW, 0), result);
---
>   RESTARTABLE(::open(dirname, O_RDONLY|O_NOFOLLOW), result);
385c385
<   RESTARTABLE(os::open(".", O_RDONLY, 0), result);
---
>   RESTARTABLE(::open(".", O_RDONLY), result);


Best regards, Matthias



> -----Original Message-----
> From: David Holmes <david.holmes at oracle.com>
> Sent: Donnerstag, 21. Februar 2019 10:27
> To: Baesken, Matthias <matthias.baesken at sap.com>; Thomas Stüfe
> <thomas.stuefe at gmail.com>
> Cc: hotspot-dev at openjdk.java.net
> Subject: Re: 8218811: replace open by os::open in hotspot coding - was :
> open-calls in hotspot code instead of os::open ?
> 
> On 19/02/2019 6:31 pm, Baesken, Matthias wrote:
> > Hi  David,  thanks  for the review .
> >
> > However I had to address  an  issue  in
> src/hotspot/os/linux/perfMemory_linux.cpp   .
> > There were  some  open calls  that deal with   ***directories*** ,  and
> there   os::open  cannot be used .
> 
> Which ones? I can't readily compare the two webrevs.
> 
> Thanks,
> David
> -----
> 
> > New webrev :
> >
> > http://cr.openjdk.java.net/~mbaesken/webrevs/8218811.5/
> >
> >
> > Best regards, Matthias
> >
> >
> >
> >> -----Original Message-----
> >> From: David Holmes <david.holmes at oracle.com>
> >> Sent: Dienstag, 19. Februar 2019 06:13
> >> To: Baesken, Matthias <matthias.baesken at sap.com>; Thomas Stüfe
> >> <thomas.stuefe at gmail.com>
> >> Cc: hotspot-dev at openjdk.java.net
> >> Subject: Re: 8218811: replace open by os::open in hotspot coding - was :
> >> open-calls in hotspot code instead of os::open ?
> >>
> >> On 15/02/2019 1:44 am, Baesken, Matthias wrote:
> >>> Hello, here is the updated  webrev :
> >>>
> >>> http://cr.openjdk.java.net/~mbaesken/webrevs/8218811.4/
> >>
> >> This seems okay to me.
> >>
> >> Thanks,
> >> David
> >> -----
> >>
> >>> Best regards, Matthias
> >>>
> >>>
> >>>
> >>> From: Baesken, Matthias
> >>> Sent: Donnerstag, 14. Februar 2019 12:43
> >>> To: 'Thomas Stüfe' <thomas.stuefe at gmail.com>
> >>> Cc: Kim Barrett <kim.barrett at oracle.com>; ioi.lam at oracle.com;
> hotspot-
> >> dev at openjdk.java.net
> >>> Subject: RE: 8218811: replace open by os::open in hotspot coding - was :
> >> open-calls in hotspot code instead of os::open ?
> >>>
> >>>> fdStream::fdStream(const char* file_name)
> >>>>
> >>>> bool _need_close;
> >>>>
> >>>> and the close() call in the constructor?
> >>>
> >>> Hi, this has nothing to do with this change.
> >>> I have very bad experience with bringing in unrelated cleanups into  a
> >> change my request after request etc.
> >>>
> >>> Will remove  the os::open  from   CompileLog::finish_log_on_error()
> and
> >> the whitespace stuff.
> >>>
> >>> Thanks, Matthias
> >>>
> >