RFR [XS]: 8219630: cleanup hotspot ostream.cpp
Thomas Stüfe
thomas.stuefe at gmail.com
Tue Feb 26 08:13:14 UTC 2019
Looks good.
Good as it is, but since you are touching the code:
- you could use initializer list instead in the ctor:
fdStream(int fd = -1) : _fd(fd) {}
- you could remove the whole destructor, since it does nothing of value
anymore.
Cheers Thomas
On Tue, Feb 26, 2019 at 9:02 AM Baesken, Matthias <matthias.baesken at sap.com>
wrote:
> Hello, please review this small patch .
>
> In the review process of 8218811 it has been noticed that ostream.cpp
> can be cleaned up a bit ; I want to address the cleanups with this change
> .
>
>
> Bug/webrev :
>
> https://bugs.openjdk.java.net/browse/JDK-8219630
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8219630.0/
>
>
> Thanks, Matthias
>
>
More information about the hotspot-dev
mailing list