RFR [XS]: 8219630: cleanup hotspot ostream.cpp

[Thomas Stüfe]

all good now :)

On Tue, Feb 26, 2019 at 10:05 AM Baesken, Matthias <matthias.baesken at sap.com>
wrote:

> Hi Thomas, thanks for the review !
>
>
>
> >
>
> >- you could remove the whole destructor, since it does nothing of value
> anymore.
>
> >- you could use initializer list instead in the ctor:
>
> > fdStream(int fd = -1) : _fd(fd) {}
>
>
>
> Sure,  new webrev :
>
>
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8219630.1/
>
>
>
>
>
> Best regards, Matthias
>
>
>
>
>
> *From:* Thomas Stüfe <thomas.stuefe at gmail.com>
> *Sent:* Dienstag, 26. Februar 2019 09:13
> *To:* Baesken, Matthias <matthias.baesken at sap.com>
> *Cc:* hotspot-dev at openjdk.java.net
> *Subject:* Re: RFR [XS]: 8219630: cleanup hotspot ostream.cpp
>
>
>
> Looks good.
>
>
>
> Good as it is, but since you are touching the code:
>
>
>
> - you could use initializer list instead in the ctor:
>
>  fdStream(int fd = -1) : _fd(fd) {}
>
>
>
> - you could remove the whole destructor, since it does nothing of value
> anymore.
>
>
>
> Cheers Thomas
>
>
>
>
>
>
>
> On Tue, Feb 26, 2019 at 9:02 AM Baesken, Matthias <
> matthias.baesken at sap.com> wrote:
>
> Hello, please review  this small patch .
>
> In the review process of 8218811 it  has been noticed that ostream.cpp
> can be cleaned up a bit ;  I want to address  the cleanups with this change
> .
>
>
> Bug/webrev :
>
> https://bugs.openjdk.java.net/browse/JDK-8219630
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8219630.0/
>
>
> Thanks, Matthias
>
>